Comment on page
Git Guidelines
This is a summary of Git best practices we follow
The most important thing about commit messages, is that it should describe what this change is about. So the message should be about the fix, not about the bug/feature.
Bad example of commit message:
Images have wrong aspect ratio ❌
Better example of commit message:
Force images aspect ratio ✅
Typically a commit message is consisted from a subject and a body. The examples above are just subject lines, but we can use the commit body elaborate on the changes included. Here is a good example.
Mental note for commit messages:
- Subject describes “What”
- Body describes “Why and How”
If the commit is connected to a specific ticket, it’s a good practice to add the ticket number to the commit subject. If the ticket is on Github it should have a similar prefix you can use.
PLANET-1234 Force images aspect ratio
Some syntax and styling rules to make git log history more consistent.
- 1.Separate subject from body with a blank line
- 2.Capitalize the subject line
- 3.Do not end the subject line with a period
- 4.
We pick a short name that makes sense and carries some context, depending on the change that a PR is introducing. Optionally you could add a prefix, depending on the kind of the PR.
These are all good branch names:
fix-breadcrumbs-spacingadd-author-avatarsfeature/change-covers-widthbug/safari-button-editing
If a Pull Request has just one commit, it automatically inherits its name from that. Otherwise make sure to add the ticket number there too, to make reviewers life easier.
Always add a link to the ticket pointing to all relevant PRs.
Sometimes a reviewer asks us to make some changes to our PR. If these changes are part of the existing work it should also be part of the existing commits, not a new one.
Fixing syntax, linting, typo errors we introduced on our commits should never be a new commit.
Assuming we have one commit already and we did some additional changes to a file. We can amend the commit and update the PR.
git add templates/footer.twig
git commit --amend --no-edit
git push -f origin planet-1234
What the above does, is that it stages the changes on footer template and amend our last commit by just adding our staged changes. If we wish to make changes to the commit message we can omit the
--no-edit option.The
-f option on the push command overrides the branch already on the remote (Github) with what we now have locally.Sometimes we run into conflicts, because other people code is merged in the meantime.
To solve the conflict we need to update locally the target branch and rebase, not merge.
Assuming we have a PR with conflicts against the main branch. We update main branch first and then we rebase our own branch:
git checkout main
git pull
git checkout planet-1234
git rebase main
Git will stop when it finds the conflicts and will ask us to resolve them. Once we do that in our editor we stage the changes and continue the rebase:
git add templates/footer.twig
git rebase --continue
When done we update the remote branch:
git push -f origin planet-1234
The important thing of this process is that your branch should never have merge commits or commits about resolve conflicts. It should only contain commits that are relevant to your work.
Remember that the
-f option means force, and it essentially rewrites history. So, it’s ok to use it for your own branches, but you should never use it for the project branches (eg. main).Last modified 2yr ago